Add support for withAnyArgs method for onFilter calls.#256
Merged
agibson-godaddy merged 6 commits into10up:trunkfrom Mar 11, 2025
Merged
Conversation
e2b231a to
03ed5e9
Compare
03ed5e9 to
3038fef
Compare
Contributor
agibson-godaddy
left a comment
There was a problem hiding this comment.
Thanks for putting this together! Just one suggestion.
withAnything method for onFilter calls.withAnyArgs method for onFilter calls.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements a new method called
withAnyArgsforonFiltercalls. This method is particularly useful in test cases where we do not care about the filter arguments passed in but just its return value like so:Closes: #156
Details
I have introduced a static array called
$filtersWithAnyArgsthat basically acts as an associative array for filter names mapped to random integer values.This array will help us store random integers at the point where the
withAnyArgsmethod is called, so that we can check for those later in theapplymethod and accurately set our passed in args.Run tests:
Contributor checklist
Testing
Create class like so:
Create Test like so:
Run test, it should pass successfully using the
withAnyArgsmethod:composer run testReviewer checklist